Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependencies, fix imports and improve build #1881

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

paulo-ocean
Copy link
Contributor

Fixes #1872

Changes proposed in this PR:

  • fix the imports and the circular dependencies

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment from my side, otherwise lgtm.

src/utils/Adresses.ts Show resolved Hide resolved
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean self-assigned this Dec 3, 2024
@paulo-ocean paulo-ocean merged commit 0bc6f0b into main Dec 12, 2024
11 checks passed
@paulo-ocean paulo-ocean deleted the issue-1872-circular-deps branch December 12, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependencies issue when building SDK
3 participants